Thanks for caring about the SDK cleanness.

A Service is rather a high-level API.

Since the type aims at providing subscription or initial value, I propose the name ObservableLiveLocation to match the other places of the SDK using a similar pattern.

Thoughts?

What about RoomLiveLocationObserver ? or LiveLocationObserver ?
ObservableLiveLocation feels a bit misleading because this object is not a LiveLocation but something that keeps track of them.

I'm good with LiveLocationObserver too. Ideally, it should live inside the matrix_sdk::room module, but let's not do too much change at once 😛.

Merging this PR will not alter performance

✅ 50 untouched benchmarks

_{Comparing mauroromito/rename_lls_shares (79c2c41) with main (b9b40c0)}

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.81%. Comparing base (9d39e4b) to head (79c2c41).
⚠️ Report is 17 commits behind head on main.
✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #6446      +/-   ##
==========================================
- Coverage   89.82%   89.81%   -0.02%     
==========================================
  Files         378      378              
  Lines      104314   104314              
  Branches   104314   104314              
==========================================
- Hits        93702    93686      -16     
- Misses       7020     7025       +5     
- Partials     3592     3603      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

A Service is rather a high-level API.

Imho this component has potential for growing, by moving the send_live_location method from the Room here and potentially caching the "local echoes". I would just name it service to being with and avoid later complications. Service also makes is consistent with our other services and set expectations on lifetime management correctly.

I let you decide then 😃.

in the end we decided to rename it to LiveLocationsObserver